fio discovery profile expansion #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brdeyo
reviewed
Aug 11, 2025
src/VirtualClient/VirtualClient.Main/profiles/PERF-IO-FIO-DISCOVERY-v2.json
Outdated
Show resolved
Hide resolved
brdeyo
requested changes
Aug 11, 2025
src/VirtualClient/VirtualClient.Main/profiles/PERF-IO-FIO-DISCOVERY-v2.json
Outdated
Show resolved
Hide resolved
added 4 commits
August 11, 2025 12:35
…m fio profiles, expanding discovery profile to include block size of 1k, using IOType and BlockSize as strings instead of lists.
brdeyo
requested changes
Aug 11, 2025
src/VirtualClient/VirtualClient.Main/profiles/PERF-IO-FIO-DISCOVERY.json
Outdated
Show resolved
Hide resolved
brdeyo
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of expansion: To eventually make the following Compete profiles obsolete and use parameters with a profile in the public repo.
Changes made to FioDiscoveryExecutor: Removed the nested for loop for max threads, io type, and block size. So now only queue depth is iterated over/permitted as a list parameter.
Changes made to PERF-IO-FIO-DISCOVERY.json: Added 1k block size.